only invoke didChange if a node is still present. #11558
Conversation
stefanpenner
force-pushed
the
only-invoke-still-present-chain-entries
branch
from
3698b56 to
77c6dfe
Compare
|
LGTM, I'd like to land the RC/AC PR soonish, timeline on adding test (then rebasing that PR)? |
|
I'll be adding an explicit test after breakfast today. Have you had a chance to test out AC/RC in your own apps? |
|
@stefanpenner - Yes, I have tested in a couple apps (I'm not using all possible macros though) and things worked (all tests pass). The only way to get more testing, is to land in canary and/or beta... |
Ya, im totally fine with it getting pulled in. :) |
|
closed by #11513 |
|
This change already exists in master, and I believe that a rebase will make this commit a noop. |
needs a test still |
|
Yep, completely agreed. |
|
if its closed i'll forget to write the test |
… only invoked if the node is present.
stefanpenner
force-pushed
the
only-invoke-still-present-chain-entries
branch
from
77c6dfe to
20b16a5
Compare
…-chain-entries only invoke didChange if a node is still present.
|
@rwjblue friendly reminder to pull this into beta |
noticed this in : #11513
introduced: https://github.com/emberjs/ember.js/pull/11536/files
[fixes #11564]